dhaumann added a comment.
One small suggestion to improve the clipboard code. INLINE COMMENTS > Module.cpp:256 > +{ > + auto clipboard = QGuiApplication::clipboard(); > + QMapIterator<QString, QString> i(collectedData); Nitpicking: Why do you declare the clipboard here, when you use it only 10 lines later? :-) Better would be: QGuiApplication::clipboard()->setText(text); So just one line at the end. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham, dhaumann Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart