drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.
I'm not sure on the wording "Output on" "Record from", I would prefer simple
"Move to" or "Move to device", but I am not native speaker so I leave others to
decide.
Can you merge the code into one block? As it is now, the code is duplicated
and the only difference is that first block uses `sourceView` and second
`sinkView`, but only one of those two blocks can ever be executed (can't be
both sink-input and source-output).
INLINE COMMENTS
> ListItemBase.qml:338
> + // remove the second condition in the if to always show it.
> + if (type == "sink-input" && sinkView.model.count > 1) {
> + contextMenu.addMenuItem(newSeperator());
`sinkView.model.count > 1` -> `sinkView.count`
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D10901
To: Fuchs, broulik, drosca
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
