drosca added a comment.

  +1. No more code comments.
  
  Just a note, we can't guarantee that audio is actually playing from that 
stream.

INLINE COMMENTS

> drosca wrote in ListItemBase.qml:338
> `sinkView.model.count > 1` -> `sinkView.count`

Sorry about this comment, it's nonsense. It was fine in your fist diff.

It must check `> 1` not just `> 0`.

REVISION DETAIL
  https://phabricator.kde.org/D10901

To: Fuchs, broulik, drosca
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Reply via email to