ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed.
Appending `.desktop` is unnecessary and a violation of the AppStream spec. See https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent > The ID must follow a reverse-DNS scheme, consisting of {tld}.{vendor}.{product}, for example `org.kde.Gwenview` or `com.hugski.ColorHug2`. Ownership of {vendor}.{tld} in the domain name system guarantees uniqueness of IDs. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D10920 To: kossebau, sebas, mart, broulik, ngraham Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
