jgrulich added inline comments. INLINE COMMENTS
> secretagent.cpp:363 > + NetworkManager::VpnSetting::Ptr vpnSetting = > connectionSettings->setting(NetworkManager::Setting::Vpn).dynamicCast<NetworkManager::VpnSetting>(); > + if (vpnSetting->serviceType() == > "org.freedesktop.NetworkManager.ssh" && vpnSetting->data()["auth-type"] == > "ssh-agent") { > + QString authSock = qgetenv("SSH_AUTH_SOCK"); Use QLatin1String() > secretagent.cpp:367 > + > + if (!authSock.isEmpty()) { > + NMStringMap secrets; When SSH_AUTH_SOCK is empty, it shouldn't continue asking for the password, you should instead report an error. > secretagent.cpp:372 > + QVariantMap secretData; > + secretData.insert("secrets", > QVariant::fromValue<NMStringMap>(secrets)); > + request.connection[request.setting_name] = secretData; Use QLatin1String() REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14035 To: catherinez, #plasma, jgrulich Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart