jgrulich requested changes to this revision. jgrulich added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > secretagent.cpp:370 > + QLatin1String("SSH_AUTH_SOCK not present"), > + request.message); > + } else { You should also return true to indicate that the request is completed, otherwise it will still continue. REVISION DETAIL https://phabricator.kde.org/D14035 To: catherinez, #plasma, jgrulich Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart