ngraham added inline comments.

INLINE COMMENTS

> image.cpp:877
> +{
> +   KRun* krun = new KRun(QUrl::fromLocalFile(path), nullptr);
> +}

This generates a warning (variable `krun` is unused). I would suggest using 
`KIO::highlightInFileManager()` instead. For example: 
https://cgit.kde.org/spectacle.git/tree/src/Gui/KSMainWindow.cpp#n327

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to