davidre updated this revision to Diff 60823. davidre added a comment.
Sort only if a sortmode has been specified Otherwise it could have been initialized to an invalid value which caused us to reach Q_UNREACHABLE and crash. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22121?vs=60725&id=60823 BRANCH slideshow (branched from master) REVISION DETAIL https://phabricator.kde.org/D22121 AFFECTED FILES wallpapers/image/CMakeLists.txt wallpapers/image/backgroundlistmodel.h wallpapers/image/image.cpp wallpapers/image/image.h wallpapers/image/imagepackage/contents/ui/config.qml wallpapers/image/imagepackage/contents/ui/main.qml wallpapers/image/slidefiltermodel.cpp wallpapers/image/slidefiltermodel.h wallpapers/image/slidemodel.cpp wallpapers/image/slidemodel.h wallpapers/image/slideshowpackage/contents/config/main.xml To: davidre, #plasma Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart