davidre added inline comments.

INLINE COMMENTS

> image.cpp:600
> +        m_slideshowModel->addBackground(path);
> +        m_currentSlide = m_slideFilterModel->indexOf(path) - 1;
>          nextSlide();

Currently the slideshow would restart. I guess we could check here if the index 
is -1. Or alternatively don't trigger this from the qml side if the image is 
unchecked. In my mind this even better because then we enable the apply button, 
too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to