On 2006-10-18 09:44+0200 Werner Smekal wrote:
>> and change from
>>
>> check_include_file("qhull/qhull_a.h" QHULL_INCLUDE)
>>
>> to the following:
>>
>> set(CMAKE_REQUIRED_INCLUDES ${QHULL_INCLUDE_DIRS})
>> check_include_file("qhull/qhull_a.h" QHULL_A_VARIABLE)
>> set(CMAKE_REQUIRED_INCLUDES)
>
> Why is this step necessary? I already look for qhull/qhull_a.h in
> FindQHULL.cmake anyway, if the file doesn't exist we never reach these
> lines?
check_include_file is a more comprehensive check (it actually attempts a
compilation using QHULL_INCLUDE_DIRS) than the simple check done in
FindQHULL.cmake that a header file with the correct name exists and can be
found. That said, I think your decision is fine to exclude the
comprehensive check. The simple check that you have now is enough and the
comprehensive check doesn't add that much additional value for the
additional time that would be required.
> I wrote a simple cmake script for qhull, which compiles the library and
> install/copies the library and header files to a directory. What should
> I do with this file, where should I commit it? I think the qhull
> community might not be interested, since it doesn't compile all the
> executables (would be very easy to add though) and since the last
> release was 2003.
You might find the qhull community becomes more active if you show interest
by attempting to donate your CMake work to their project. Anyhow, I suggest
that is the first thing you should do. If you get no quick response from
the qhull community, then I agree you should make an additional CVS
directory to store your CMake work for external projects that some of our
users will need to build as a convenience for those users. If required,
that new directory should probably go under our current cmake directory.
Would "cmake/external_projects" be a good name for that directory or is
there a better name you can think of?
> I hope that these changes don't break anything on Linux - it's not
> possible for me in the moment to easily check this. So it would be good
> if these changes are tested and reviewed on other platforms.
I just had a clean build and ctest result with current CVS (including all
your recent changes and other recent changes as well since I last did such a
check). However, example 21 (which is the only example to test the
functionality of the csiro libraries) is specifically not tested as part of
ctest in the build tree (or the run of plplot-test.sh for the installed
examples). The reason is there is some built-in randomness to the results
(via a call to a timing routine) that gives inconsistencies from one run to
the next. So I individually tested example 21 as well, and the CSIRO results
(cubic spline, Delaunay triangulation, and natural neighbours) looked good
compared to other grid interpolation algorithms.
In sum, it appears all your changes are fine on the Linux platform. Good
work!
I also just committed some clarifications to the FindQHULL.cmake commentary.
Alan
__________________________
Alan W. Irwin
Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).
Programming affiliations with the FreeEOS equation-of-state implementation
for stellar interiors (freeeos.sf.net); PLplot scientific plotting software
package (plplot.org); the Yorick front-end to PLplot (yplot.sf.net); the
Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project
(lbproject.sf.net).
__________________________
Linux-powered Science
__________________________
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel
