On 2007-07-17 04:15-0700 Jerry wrote: > On Jul 4, 2007, at 6:54 PM, Alan W. Irwin wrote: >> One thing revealed by this example (2) is our Ada bindings were much too >> conservative about the allowed range of plcol0 indices. I changed >> that from >> 0..15 to the much more reasonable 0..255. Example 2 uses 116 >> different >> cmap0 indices, but some users may want more. > > I removed the range limitation completely so now the index is a full > 32 bits. I don't think there is much reason to limit it to 256 or to > any other number less than 2^32 unless there is a threshold over > which we can definitely discern that a user is making a mistake. Even > with the range opened up, Ada still checks the type, Plot_Color_Type. > >> I chose to limit the range in >> the bindings to 0..255 since that corresponds to 24 bits total for >> r, g, and >> b and is more than adequate to handle example 2. > > Not sure I understand, since 256 is the number of map entries, not > the bits per color.
Just to explain, I was thinking of the old-fashioned colour pallette method of representing colours, but now that you have brought it up, I don't think that is ever used for 24-bit colours so my comment was not relevant. Anyhow, I agree with your change to open it up completely. >> Jerry, please review and correct any strange things I did in Ada for >> x02a.adb. >> > Done (nothing strange). Thanks, Jerry, for that review. You might turn me into a real Ada programmer eventually. :-) Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
