On 2008-10-09 23:42-0500 Maurice LeBrun wrote: > On Saturday, October 4, 2008 at 16:46:53 (-0700) Alan W. Irwin writes: > > I made the empty-page fix, and indeed that fixed the example 23 issue for > > the pages which consisted just of text (see my recent post on the svg > > status). However, in my view those text-only pages (done with > > plP_esc(PLESC_HAS_TEXT...) should have set the DRAWING status if that status > > is to be meaningful at all. > > > > What do you think about setting the DRAWING status generally for both > > plP_esc and plP_state? > > That should be ok. The main thing to worry about are the AT_BOP and AT_EOP > values, so the pagination commands don't get confused. Be aware there may be > some situations where you set state to DRAWING when you are actually between > pages, but that shouldn't affect anything. I may have originally had more > plans for DRAWING but now I forget.
My fix dealt with both the empty page case and the PLESC_HAS_TEXT case. In both cases DRAWING is not currently set and the updated familying logic works finally for all the examples and drivers that are tested by ctest. Therefore, I suspect it may not be necessary to set DRAWING in any case. However, I don't really understand this code completely, and it appears to work fine now so I think I will leave it in its present state rather than either dropping the DRAWING status or expanding its use to the case of plP_esc and plP_state. > I read through your doc, it looks good except the warning not to mix pladv() > and plbop/pleop is perhaps a bit too strong. Thanks for that review. I am glad it is basically correct. I don't care one way or the other about the exact wording so I would prefer you just go ahead and commit the wording changes you prefer. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
