On Tue, Jun 23, 2009 at 02:31:08PM +0300, Dmitri Gribenko wrote: > On Tue, Jun 23, 2009 at 11:28 AM, Andrew > Ross<andrewr...@users.sourceforge.net> wrote: > > Technically this is akin to an API change since some of these symbols > > have been visible for a long time (pre cmake I think) and so some > > users might rely on then. This is what I wanted feedback on. > > We could still install plConfig.h but remove all references to it from > user-visible headers. Thus users who rely on it could include it > themselves. > > Also, it would be better to hide all internal declarations altogether. > It could be easily done like this: in all sources we define a macro, > say IN_PLPLOT_CORE and check for it in all headers. All internal > stuff in headers should be guarded #if IN_PLPLOT_CODE ... #endif. The > macro can be defined on the command-line of compiler, > -DIN_PLPLOT_CORE=1, so only modifications to headers is necessary.
This still doesn't get round the problem of python leaking these declarations. For that we would have to rename the declarations to something like PLPLOT_HAVE_ISINF. Andrew ------------------------------------------------------------------------------ Are you an open source citizen? Join us for the Open Source Bridge conference! Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250. Need another reason to go? 24-hour hacker lounge. Register today! http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
