On Mon, Sep 21, 2009 at 12:25:12PM -0700, Alan Irwin wrote: > On 2009-09-21 09:49+0100 Andrew Ross wrote: > > > [...]The markup comment style is a little quirky, but I can live with that. > > I'll hold > > off any crustify changes to the code until we decide on this. > > Hi Andrew: > > I am concerned we move forward with uncrustify soon so there will be plenty > of time to test the full conversion results (and adjust if necessary by > tweaks to uncrustify.cfg) before our next release. > > I think the uncrustify project is independent of Werner's doxygen project so > the order of which gets done first doesn't matter that much. In fact, > putting all our comments into a standard form with uncrustify would probably > help Werner a bit. I presume he is converting the comments near the head of > each function to doxygen form and it always easier to convert from one > consistent form (rather than a grab-bag of forms). > > I just double-checked that doxygen-style comments and uncrustify are > compatible. For your information there was a bug reported about that at > http://sourceforge.net/tracker/?func=detail&aid=2792426&group_id=153164&atid=786647 > but it turned out to be an artifact of non-zero indent_with_tabs. This > should not be a problem for us since uncrustify.cfg sets indent_with_tabs to > 0. > > Anyhow, I suggest you just go ahead with doing your last tweaks of > uncrustify.cfg (if any more are necessary) to make sure Werner's plpage.c > doxygen changes are preserved, and you are otherwise satisfied with the > style. Then convert src and bindings/c++ to that standard style as a > substantial proof-of-concept for C and C++ code which we can all evaluate > before you do the full conversion of all our C and C++ code. That last > step might have to be repeated with more minor tweaks to uncrustify.cfg, > but it would be good to get at least one full iteration of this process > done in the near future for the reasons I mentioned above.
I have gone ahead and committed a uncrustified version of plpage.c. This does not seem to have affected the doxygen comments. The changes in this case were relatively minor suggesting that we have a good "style". The core code is on the whole far more uniform. If people are happy I will progress with the rest of src/ and bindings/c++. Andrew in coding style. It would be nice to bring the rest of the code into line. ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
