On Jan 6, 2010, at 23:15 , Alan W. Irwin wrote:

I applied the second version you sent me off list (without the interfering
linewraps) and it seemed to work well.  I restyled one line consistent
with our code style (as enforced by scripts/style_source.sh -- apply), and
committed the result (revision 10741).

Thank for telling me about scripts/style_source.sh. I notice that it requires uncrustify 0.53, but MacPorts is up to version 0.54 of uncrustify. Do you know if it's truly incompatible with 0.54 or has it just not been tried yet? If necessary, I can probably find and install 0.53, but it would be much easier for me to use 0.54. Maybe I can be the guinea pig.

Thanks!

You're welcome and thank YOU!

Do you have a suggestion about the best place to document this new
functionality in our DocBook-generated documentation?

Some would say that you should have rejected my patch because it didn't include documentation! =8-O

I've rectified that with the attached patch. I didn't see any obvious docbook styling scripts, do I tried to make my changes match the existing style as best I could. I finally managed to get "make validate" working on my Mac (see next patch email from me) and the changes in the attached patch validated.

Dave

Attachment: 0001-Documentation-for-PLPLOT_DEV-enrironment-variable.patch
Description: Binary data



------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to