On Thu, May 27, 2010 at 04:39:55PM -0400, Hazen Babcock wrote: > Andrew Ross wrote: >> On Thu, May 27, 2010 at 03:49:22PM -0400, Hazen Babcock wrote:
>>> Are we sure that we are closing the QApplication properly? >> >> I think so, although most programs would only create a QApplication once >> at the beginning of the program then delete it at the end, so resource >> leaks might not be obvious. > > I believe that is what we are doing too in these tests. > >> You could try valgrind with things like --track-fds to see if there is a >> leak of file descriptors? > > Attached, not sure what to make of it, except that we don't close test.png? > > Let me know if there is anything else I can run that would be informative. Well clearly the output files should be properly closed. I've now fixed that. You could try again, although I don't think that is the problem. You could try again to check. Potentially more interesting are the open pipes. I notice that most drivers just call fclose( pls->OutFile ) which unconditionally closes the output file descriptor. Usually this is right, but I would argue that if the output is to stdout then this is not the right thing to do. If people agree I would suggest adding a plCloseFile to parallel plOpenFile which checks if the output is to stdout before calling fclose. Andrew ------------------------------------------------------------------------------ _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
