On Thursday 12 Dec 2013 10:18:38 Alan W. Irwin wrote: > On 2013-12-12 08:41-0800 phil rosenberg wrote: > > Hi All > > I've just hit a few other CMAKE snags, but this time they seem to be > > related to 64 bit builds only and in this case they can be worked around, > > but I thought people here might have some comments. This is all for > > WIndows 8 using Visual Studio 2012 and CMAKE 2.8.12.1 > > > > 1) When trying to generate a 64 bit build CMAKE appends /machine:x86 to > > the linker command line, which overrides the earlier /machine:x64. It > > does this for deltaT-gen, parity_bit_check, plhershey-unicode-gen, pltek, > > tai-utc-gen, test_plend and all examples, but not for the actual plplot > > library and the c++ library. I wondered if anyone else has seen this - > > Arjen, do you see this on your Windows system? > > > > 2) CMAKE is not defining anything in plConfig.h. Again this only happens > > for 64 bit builds. The immediate impact is that the using namespace std; > > line is #ifdef'd out of all the C++ files giving compile errors. > > > > 3) Was only highlighted by 2). Because PL_HAVE_SNPRINTF etc are not > > defined plsnprintf and plsnscanf are both compiled and they generate > > compile errors. I guess these functions are basically never compiled so > > the errors have slipped through. I've attached a patch if it is useful. > > > > I'm not sure if issue 1 and 2 are due to CMAKE or are Plplot specific. Any > > thoughts anyone? > Andrew, could you evaluate the patch?
Alan, The patch is fine. As Phil says the code must never have actually been compiled in practice (which probably means we don't need it any more!) I've applied the patch anyway to fix the problems. > Arjen, I don't have the expertise to deal with any of the rest of > these Windows issues so it is up to you. > IMPORTANT.... Please advise whether you feel these issues are > release-critical or not. And if so, how much you feel the release > schedule will need to be delayed to give you a chance to deal with > them. Hopefully Arjen can confirm / deny these problems, but given the strenuous efforts we've made to make plplot work on Windows it would be a shame to have a release with a show-stopper. If a (short) delay e.g. a few days would be sufficient to fix this, then I'd say it was worth it. Afraid I don't have a suitable setup to help test this either so it will be over to Phil / Arjen. Andrew ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ Plplot-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/plplot-devel
