On 2014-01-15 04:59-0800 phil rosenberg wrote: > Hello Alan
> I hadn't spotted the dependence from pllegend. I should have checked more examples than I did. I had also assumed that as it was currently being calculated incorrectly using Hershey fonts then it shouldn't have been used anywhere. Anyhow, I have amended things as you suggested. Please find attached three patches, one patches the core plplot library to allow graceful continuation if the Hershey fonts aren't available, the second provides text width when using freetype, the third provides text width when using wxWidgets. > A couple of additional comments: > I changed the plabort to plwarn for if the hersey fonts aren't loaded for a driver rendering its own text. I didn't remove it completely because plpoin and plsym cannot draw text without the fntindx read from the files, so there is a loss of functionality. Each call to these functions results in a plabort call if the fonts have not been loaded. > Also all the widths provided are for the first line in the case of a string containing '\n'. This was as much for ease of programming as anything else, but I wasn't sure that any other option was better. We have discussed in the past having plplot deal with layout before passing things to the drivers. Perhaps eventually this is what is needed to give consistent support for newlines. Hi Phil: These changes all sound good, and the plfreetype one should help other devices (I think wingcc is the only one) that still use the plfreetype approach even after you go ahead with your planned removal of the plfreetype approach from wxwidgets. Putting on my release manager hat, as noted in a previous post to this list, I am planning to release 5.10.0 on February 1st (only 2+ weeks from now) so I think it is already too late in the present release cycle for big changes such as your patches. But just after the release I plan to try extensive tests (e.g., complete testing of all devices on all standard examples on Linux with *.fnt files unavailable) of your patches on Linux, and assuming those tests pass, and you are satisfied with similar extensive testing on Windows I will commit your patches. This should give us a full release cycle to make sure there are no unintended consequences of your changes. I also suggest that if you have other wxwidgets patches prepared (such as removal of plfreetype, etc., that we discussed before), those patches can also be evaluated and applied just after the 5.10.0 release. Note it is important for those additional patches to be completely separate from the present three patches, though, to make it easier to understand your changes. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ Plplot-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/plplot-devel
