> On May 31, 2015, at 10:11 PM, Jim Dishaw <j...@dishaw.org> wrote: > > Yep, I will take a look > > > >> On May 31, 2015, at 9:32 PM, Alan W. Irwin <ir...@beluga.phys.uvic.ca> wrote: >> >>> On 2015-05-31 22:06+0100 Phil Rosenberg wrote: >>> >>> Hi Alan >>> You should now find that the plbuf.c warning is gone. I haven't >>> touched the plmeta files. I will leave these to Jim as I don't know >>> that code well. >> >> @ Phil: I confirm you fix, and thanks! >> >> @Jim: >> >> The remaining warnings are >> >> /home/software/plplot/HEAD/plplot.git/src/plmetafile.c: In function >> ‘read_header’: >> /home/software/plplot/HEAD/plplot.git/src/plmetafile.c:341:8: warning: >> ‘pdf_rc’ may be used uninitialized in this function [-Wuninitialized] >> /home/software/plplot/HEAD/plplot.git/src/plmetafile.c:306:9: note: ‘pdf_rc’ >> was declared here >> /home/software/plplot/HEAD/plplot.git/src/plmetafile.c: In function >> ‘plreadmetafile’: >> /home/software/plplot/HEAD/plplot.git/src/plmetafile.c:378:23: warning: >> ‘plm’ may be used uninitialized in this function [-Wmaybe-uninitialized] >> /home/software/plplot/HEAD/plplot.git/src/plmetafile.c:1117:14: note: ‘plm’ >> was declared here >>
I think these two patches will fix the warnings (I don’t get any warnings with clang, but it does not have the -Wmaybe-uninitialized option).
0001-Fixed-uninitialized-value-warning-in-plreadmetafile.patch
Description: Binary data
0002-Fixed-uninitialized-variable-error-in-read_entry.patch
Description: Binary data
------------------------------------------------------------------------------
_______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
