On 2015-06-02 11:50-0400 Jim Dishaw wrote: > When I was working on reviving my new windows driver, I took a detour on cleaning up some code to help improve warnings and errors.
> The attached patch series moves the plwarn() etc from plctrl.c to a new file plerror.c. I also cleaned up a bunch of fprintf(stderr, …) into plwarn() or plexit() calls and removed some exit() calls. I modified plwarn() etc to use variable arguments and was able to eliminate some buffer arrays. > The changes appear not have broken anything (though it is hard to test because most of the changes execute on errors). Any volunteers on testing before applying to the repository? As you say, testing of response to error conditions is really hard. Certainly it is beyond the scope of the comprehensive_testing.sh script. Also, I suspect there is a combinatorial problem so getting complete testing of all error possibilities is essentially impossible. So I think this is a case where you are going to have to rely on the source code experts here who are currently actively developing PLplot to evaluate your patch series by actually looking at your code changes. The list of such developers excludes me (I really don't feel I have the required C expertise), but it does include you, and I also hope at minimum that Arjen, Andrew, and Phil all take a look at your changes. If an early consensus is achieved that those code changes are a good idea and there are no obvious mistakes in them that would interfere with normal testing, then as release manager I would be happy to push those changes during this release cycle. But if no such consensus develops quickly, then I will probably want to put off pushing these changes until a later release cycle if at all. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
