On Mon, Apr 29, 2002, Michael Nordstr�m wrote: > I will take a closer look at your patch before the end of this week.
I took a quick look at the patch this evening and although the idea is OK, the implementation has some problems. - Problems with several dashes in a row, e.g. if you have a line like this, foobar -------------------------------------------------- foobar then everything after the first foobar will disappear... - The adjacentDashes variable is of type UInt8 and is increased everytime a dash is encountered, but the only check is if this variable is more than zero or not, i.e. it more or less works like a boolean variable, so why not use a boolean variable? - You never save the current height. BTW, I don't think it should be that difficult to solve the case when the dash is the first token in a word -- just check if the previous token was a space or if the dash is the first token on the line. /Mike
