On 15 Oct 2002 at 10:05, Fringe Ryder wrote:

> >I could have sworn that at some point in the past, alt_maxheight=0 and 
> >alt_maxwidth=0 turned
> >off linked alternate renditions. What should be entered into 
> >plucker.ini/.pluckerrc nowadays to
> >keep them out?
> 
> Looking at the source code, my guess is that providing NO alt_maxwidth and 
> alt_maxheight disables the alternate images.  That's fundamentally 
> different from them being 0; If they're set at all, they're applied.  I 
> don't quickly see what happens when you append an image with size 
> attributes of zero, but none-the-less it does call append.
> 
> This would be an easy fix if we can all agree on expected behavior.  I 
> don't see a special value for zero from a quick peruse, and I do see 
> precisely where the code could be modified to prevent linking an alternate 
> image if either alt_maxwidth or alt_maxheight was set to zero. 

Nice catch, that is it exactly.

In looking at the the source, the default when reading from config, seem to be "None".
That seems to mean if the plucker.ini/.pluckerrc doesn't specify a certain 
alt_maxwidth and 
alt_maxheight, then it is impossible to get any alternate renditions. This may have 
explained 
some of the unsolved cases of people using just manual editing of the file and 
command-line 
tools being unable to retrieve any images.

The current situation of "None" won't work, I don't think, because if a section of the 
plucker.ini/.pluckerrc says a  
alt_maxwidth=
to try to say don't include any alternate renditions, this won't work. Because 
instead, it will 
go up the heirarchy and use the values from alt_maxwidth from [DEFAULT] section. There 
needs to 
be a value, like a "0" in the section, such that a channel section can override the 
[DEFAULT] 
section.

I agree with Tony though, a discussion of what shold be done is a good idea before 
actually 
changing it.

Best wishes,
Robert
_______________________________________________
plucker-list mailing list
[EMAIL PROTECTED]
http://lists.rubberchicken.org/mailman/listinfo/plucker-list

Reply via email to