squiffy said the following on 05/01/2006 15:53:
> Robin Bowes Wrote:
>
>>It didn't work for me - the command-line options to cdparanoia are
>>wrong, and there's a regex that doesn't work as intended.
>>
>>I'll post a patch when I've sorted it out.
>>
>>But, great concept.
>>
>>R.
>>
>
>
> Robin,
>
> You are way ahead of me on this one...I would not have recognized the
> command line options being wrong, anyway. However, it worked for me
> right out of the box on Kubuntu 5.10 from the command line...I mean
> zero issues.
>
> I have noticed a couple of things in the perl script that document
> reminders to the original author to 'fixme'. If you can post a patch,
> dandy neat-o for all.
>
> Lastly, I forgot to mention that there is a handle in the AutoRip perl
> script to call 'mp3gain'. If you add mp3gain (apt-get'able for all you
> Debian variant types), it will normalize your collection during the fly
> to prevent any screaming surprises on playback...hey, one less thing to
> worry about.
>
> Query Robin: what flavour of Linux are you running and what version of
> perl?
This was on Fedora Core 4 with:
cdparanoia-alpha9.8-25 (rpm)
perl-5.8.6-22 (rpm)
With the original code, autorip just exists with the message "Error
accessing CD:"
I made the following changes to make it work:
--- autorip.orig 2006-01-04 20:38:34.000000000 +0000
+++ autorip 2006-01-05 02:03:30.000000000 +0000
@@ -363,9 +363,9 @@
print "Waiting for next disk...\n";
{
while (1) {
- my $error = `$cdparanoia -qQ 2>&1`;
+ my $error = `$cdparanoia -vsQ 2>&1`;
last if (($? >> 8) == 0);
- unless ($error =~ m/^004: /) {
+ unless ($error =~ m/^004: /xms) {
print "Error accessing CD: $error\n";
exit(1);
}
I can't see how using -q in the cdparanoia options can ever have worked
as the following code depends on checking the output of the command
which is supressed by the -q option.
This is the output from cdparanoia if there is no disc in the drive:
cdparanoia III release 9.8 (March 23, 2001)
(C) 2001 Monty <[EMAIL PROTECTED]> and Xiphophorus
Report bugs to [EMAIL PROTECTED]
http://www.xiph.org/paranoia/
Checking /dev/cdrom for cdrom...
DMA scatter/gather table entries: 1
table entry size: 131072 bytes
maximum theoretical transfer: 55 sectors
Setting default read size to 24 sectors (56448 bytes).
CDROM model sensed sensed: SONY DVD RW DRU-500A 1.0g
Checking for SCSI emulation...
Drive is ATAPI (using SCSI host adaptor emulation)
Checking for MMC style command set...
Drive is MMC style
Error reading command:
43 00 00 00 00 00 01 00 0c 00
004: Unable to read table of contents header
Unable to open disc. Is there an audio CD in the drive?
Autorip is simply checking for the "004: " string at the start of a
line. Or rather is wasn't because the regex didn't work as the author
expected. Again, I don't see how this can ever have worked!
I too will probably modify the script to produce different file names,
use flac, etc. etc.
It will be great for all CDs that are in FreeDB + cddb. But most of mine
aren't so I'll still have to rip manually.
I will be interesting to compare rips on EAC with cdparanoia. I wonder
if cdparanoia uses the drive offest?
R.
--
http://robinbowes.com
If a man speaks in a forest,
and his wife's not there,
is he still wrong?
_______________________________________________
plugins mailing list
[email protected]
http://lists.slimdevices.com/lists/listinfo/plugins
