On 23-Apr-06, at 3:46 AM, Phil Meyer wrote:
I was trying to browse PublicRadioFan from my SqueezeBox this morning,
not knowing that my ADSL connection had dropped. This plugin doesn't
handle the inability to connect very nicely at the moment. As I tried
to drill down into sub-menus, it showed blank screens and error
messages and got into a bit of a mess. I can't remember exactly what
it reported, but essentially I think it tried to go into a sub-menu,
when it hadn't retreived any data to be able to present that screen.
If it helps at all, I had a look in the slimserver trace and can see
the following:
2006-04-23 09:16:14.4232 Couldn't push into new mode:
[PublicRadioStreams] !: Can't call method "parent" on an undefined
value at
P:/Music/SlimServer/trunk/server/Plugins/PublicRadioFanBrowser.pm line
505.
Unfortunately, that bit of code is part of an internal function of the
plugin itself, and there is little that the server can do to avoid a
bad bit of code in this section of the plugin. I have done some
updates for server compatibility in the past, and recently another
author has taken on the task of helping to merge it with more recent
streaming code. Even with that, this plugin is largely unmaintained.
Simplest thing I can think of, if anything just to avoid the crash at
THAT line, rewrite line 505 like so:
if ($prog) {
$prog = $prog->parent->parent;
}
however, I'm not sure how much this will help, since I cant tell what
the full nature of the error is. It might just bail out a few lines
later :)
-k
_______________________________________________
plugins mailing list
[email protected]
http://lists.slimdevices.com/lists/listinfo/plugins
