Re: [SlimDevices: Plugins] BBCiPlayer V1.5.2 beta test

[mavit]

Previously, the “on air” information for live broadcasts scrolled
continuously.  This patch causes the setting “Player → Display
→ Scroll Mode” to be observed, allowing the user to choose whether
to scroll, to scroll once and stop, or to remain static.

While I was there, I appended the programme name to the station name.  I
also added the programme description to the third line of the display
(on supported hardware, when enabled by setting “Player → Display
→ Font” to “threeline”).

I feel that the setting “Advanced → BBC iPlayer → Live Text
- Squeezebox Classic” doesn’t feel worth it to me, and so I’ve left it
out for now, but I’m keen to hear what people think about that.  I
wonder if it’s worth working on getting the setting “Interface →
Title Format” to be observed, here, instead.

Anyway, here are the changes:


Code:
--------------------
    
  diff -ur /tmp/BBCiPlayer/BBCOnAir.pm ./BBCOnAir.pm
  --- /tmp/BBCiPlayer/BBCOnAir.pm       2017-07-01 15:29:25.000000000 +0100
  +++ ./BBCOnAir.pm     2017-10-19 20:06:37.459999787 +0100
  @@ -350,26 +350,16 @@
  
        if (!$args->{'trans'} && $song && $song->pluginData && (my $self = 
$song->pluginData->{'bbconair'})) {
  
  -             my ($complete, $queue) = 
$client->scrollTickerTimeLeft($args->{'screen2'} ? 2 : 1);
  -             my $title =  $client->streamingSong->track->title;
  -             my $ticker = $complete == 0 ? $self->text : "";
  -
  -             if ($prefs->get('livetxt_classic_line') == 0) {
  -                     # scrolling on top line
  -                     $parts = {
  -                             line    => [ undef, $title ],
  -                             overlay => [ undef, 
$client->symbols('notesymbol') ],
  -                             ticker  => [ $ticker, undef ],
  -                     };
  -             } else {
  -                     # scrolling on bottom line (normal scrolling line)
  -                     $parts = {
  -                             line    => [ $title, undef ],
  -                             ticker  => [ undef, $ticker ],
  -                     };
  +             $parts = {
  +                     'line' => [
  +                                $client->streamingSong->track->title.
  +                                ': '. $self->song->pluginData->{'track'},
  +                                $self->text,
  +                                $self->song->pluginData->{'rp_description'},
  +                     ],
  +             };
  
  -                     $client->nowPlayingModeLines($parts);
  -             }
  +             $client->nowPlayingModeLines($parts);
  
                # special cases for Transporter second display
                if ($args->{'screen2'}) {
  
--------------------


------------------------------------------------------------------------
mavit's Profile: http://forums.slimdevices.com/member.php?userid=10203
View this thread: http://forums.slimdevices.com/showthread.php?t=106409


_______________________________________________
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins