mherger wrote: > > > Yep, something I've wanted to address for a while... > > https://github.com/Logitech/slimserver/issues/397 > :) > > > > To measure the performance effect, I modified the MAI ImageProxy > cache > > to use the utf8-escaped artist names instead of the Artist IDs, and > the > > ArtistPictureLookup time for 1287 artists dropped from 40 seconds on > the > > first scan down to 3 seconds on subsequent scans! After making some > > Yeah, that should work - except in the rare case of two different > artists of the same name, which got different Musicbrainz IDs. > Do you get the IDs from MusicBrainz? If so, why do they change on each scan (and why are mine so much shorter than MusicBrainz IDs)? > > > > small changes to CustomBrowse and TrackStat to use the new cache > keys, > > things seem to work alright, at least in a quick ride around the > block. > > How would these plugins interact with the MAI cache? > CustomBrowse artist menus use MAI's artist image. https://github.com/erland/lms-custombrowse/blob/1c61b27e75b29c8541d06665fff4cbf895c3a182/src/MenuHandler/BaseMenuHandler.pm#L1092 Likewise, TrackStat most-played (and least played) artist menus get the artist image. https://github.com/erland/lms-trackstat/blob/fe583776eafce682086a0cc2731a8676b67652f6/src/Plugin.pm#L3505
> > > > Does my analysis seem correct? Is there anything wrong with my > solution? > > I'm happy to share the code changes. Does anything in addition to > > Yes, please share with me. > How should I share them? Although based on your mention of MusicBrainz IDs above, I'm not sure my change is the right approach. What if we could put a stable ID in the database (e.g., MusicBrainz if found, and a hash of the artist name if not)? That seems like it could maintain the performance improvement while still addressing the problem of identically-named artists and without the need to change Erland plugins (which is problematic to say the least...). ------------------------------------------------------------------------ mps's Profile: http://forums.slimdevices.com/member.php?userid=36351 View this thread: http://forums.slimdevices.com/showthread.php?t=99537 _______________________________________________ plugins mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/plugins
