bitspiel wrote: > Added some new music to my library and noticed that a couple of the > purchased flac tracks were sampled at 48K. > > My classics have no problem playing the 48K variants, but softsqueeze > had issues (sort of like pitch shifting down). > > So I pulled the code on the two respective products and tweaked the strm > protocol. I had to change not only softsqueeze but also the server as > well. (Specifically I needed the server to not always send '?' as the > sample rate for all flac files and modify softsqueeze to react to the > given sample rate.) > > The question I have is there any point in re-contributing these changes > back to the repositories? Both products are essentially dead. > > Further complicating the decision is the question of is my "solution" > the best practice? > > Anyone have some constructive thoughts here?
As a curiosity, why adding sample rate in the strms ? Normally, flac is self describing and you find it in the block header (that's what I'm doing on my client). I feel the mod should rather be making sure that soft squeeze correctly reads the header. They are variants in how the rate is coded In flac, but they are not difficult to handle and would give you the result without mods on the server side. LMS 7.7.2 - 5 radio, 3 Boom, 4 Duet, 1 Touch, 1 SB2. Sonos 2xPLAY:1, PLAY:3, PLAY:5, Marantz NR1603, JBL OnBeat, XBMC, Foobar2000, XBoxOne (sort of) ------------------------------------------------------------------------ philippe_44's Profile: http://forums.slimdevices.com/member.php?userid=17261 View this thread: http://forums.slimdevices.com/showthread.php?t=103688 _______________________________________________ plugins mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/plugins
