At quick glance they don't look to be a problem. I think in most
situations they were inserted when a private member was set in the
constructor and not modified elsewhere. Seems reasonable, but we should
just remember in the future that there's no reason they need to be final.
Carsten Ziegeler wrote:
David H. DeWolf wrote:
it looks like there were also several things marked as final that
weren't previously. were those changes intentional?
Argh, no they were not - it's this nice "save actions" features of
eclipse which can do a lot of things to your code when saving. It was
turned on unintentionally...no I think these changes do not hurt, so I
think we don't need them to rollback. WDYT?
But I will take care that this will not happen again.
Thanks
Carsten
