On 10/07/2010 15:35, Milan Jurik wrote:
I managed to install OSOL build 134 on a Toshiba Tecra M11:
  - using Vesa mode

Im seeing a lot of messages like:
  Unknown domain coordination type: 4 ... !?

This message?

http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/i86pc/os/cpupm/cpupm_mach.c#661
Hmm, ...

  616   cpupm_state_domains_t  
<http://src.opensolaris.org/source/s?defs=cpupm_state_domains_t&project=/onnv>         
*state_domain  <http://src.opensolaris.org/source/s?refs=state_domain&project=/onnv>;
    617 cpuset_t  <http://src.opensolaris.org/source/s?defs=cpuset_t&project=/onnv>       
    set  <http://src.opensolaris.org/source/s?refs=set&project=/onnv>;
    618...
    624
    625 *switch*  (state  
<http://src.opensolaris.org/source/s?defs=state&project=/onnv>) {
    626 *case*  CPUPM_P_STATES  
<http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/i86pc/os/cpupm/cpupm_mach.c#CPUPM_P_STATES>:
    627         state_ops  
<http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/i86pc/os/cpupm/cpupm_mach.c#state_ops>
  =mach_state->ms_pstate  
<http://src.opensolaris.org/source/s?defs=ms_pstate&project=/onnv>.cma_ops  
<http://src.opensolaris.org/source/s?defs=cma_ops&project=/onnv>;
    628         state_domain  
<http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/i86pc/os/cpupm/cpupm_mach.c#state_domain>
  =mach_state->ms_pstate  
<http://src.opensolaris.org/source/s?defs=ms_pstate&project=/onnv>.cma_domain  
<http://src.opensolaris.org/source/s?defs=cma_domain&project=/onnv>;
    629         *break*;
    630 *case*  CPUPM_T_STATES  
<http://src.opensolaris.org/source/s?defs=CPUPM_T_STATES&project=/onnv>:
    631         state_ops  
<http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/i86pc/os/cpupm/cpupm_mach.c#state_ops>
  =mach_state->ms_tstate  
<http://src.opensolaris.org/source/s?defs=ms_tstate&project=/onnv>.cma_ops  
<http://src.opensolaris.org/source/s?defs=cma_ops&project=/onnv>;
    632         state_domain  
<http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/i86pc/os/cpupm/cpupm_mach.c#state_domain>
  =mach_state->ms_tstate  
<http://src.opensolaris.org/source/s?defs=ms_tstate&project=/onnv>.cma_domain  
<http://src.opensolaris.org/source/s?defs=cma_domain&project=/onnv>;
    633         *break*;
    634 *default*:
    635         *break*;
    636 }
    637
    638 *switch*  (state_domain  
<http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/i86pc/os/cpupm/cpupm_mach.c#state_domain>->pm_type
  <http://src.opensolaris.org/source/s?defs=pm_type&project=/onnv>) {

That can't be good. If state is not CPUPM_P_STATES <http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/i86pc/os/cpupm/cpupm_mach.c#CPUPM_P_STATES> or CPUPM_T_STATES <http://src.opensolaris.org/source/s?defs=CPUPM_T_STATES&project=/onnv>, don't bother setting state_domain and then immediately dereference some garbage from the stack. Surely there should be at least an cmn_err and return there, if not an assert ... I'm sure the function is always called with state being one of the two, but still.

Sorry, reading it just raised the hairs on the back of my neck.

Rob

--
E-Mail: [email protected]               PHONE:  +44 24 7652 3037
Rob McMahon, IT Services, Warwick University, Coventry, CV4 7AL, England

_______________________________________________
pm-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pm-discuss

Reply via email to