Hi Florian, Thank you very much for your patch. I did not commit it yet, because I am not sure if returning a boolean is the best choice here. I think the input range to the method is clearly defined (i.e. must be a multiple of 90), so it should be ok to throw an exception if another value is passed. Can you update your patch to throw an ePdfError_ValueOutOfRange, please?
Thanks, Dominik On Tue, Sep 27, 2011 at 11:05 AM, Florian Aspart <[email protected]> wrote: > Hi everybody, > > I already send this mail for few days, but I wasn't registered as an user > and I'm not sure if this mail arrived. > > I just wanted to send a small patch. > I needed to set PdfPage's rotation, there was already a getter but the > setter was missing so I just add one. > It's just a few line of code, the setter only set the dictionary key: > 'Rotate'. > > Cheers, > Florian > > > ------------------------------------------------------------------------------ > All the data continuously generated in your IT infrastructure contains a > definitive record of customers, application performance, security > threats, fraudulent activity and more. Splunk takes this data and makes > sense of it. Business sense. IT sense. Common sense. > http://p.sf.net/sfu/splunk-d2dcopy1 > _______________________________________________ > Podofo-users mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/podofo-users > > ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 _______________________________________________ Podofo-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/podofo-users
