Hi Florian, Thanks for reminding me of your mail! My mailbox is just to crowded at the moment .... I committed your patch! Thank you very much for your contribution. Hopefully we will get some more :-)
Cheers, Dominik On Wed, Oct 12, 2011 at 2:36 PM, Florian Aspart <[email protected]> wrote: > Hi Dominik, > I just found out that my last mail was send in a HTML format so I > don't know if you could read my mail including the error raising > version of the patch... > Regards, > Florian > > 2011/9/27 Florian Aspart <[email protected]> >> >> Hi forgot to include the list: >> >> Hi Dominik, >> >> here is the patch with the ePdfError_ValueOutOfRange error instead of the >> boolean. You are rigth it's better to send an exception, I just inspired me >> from the SetPageWidth and SetPageHeight functions which return a boolean. >> >> Regards, >> Florian >> >> 2011/9/27 Dominik Seichter <[email protected]> >>> >>> Hi Florian, >>> >>> Thank you very much for your patch. >>> I did not commit it yet, because I am not sure if returning a boolean >>> is the best choice here. I think the input range to the method is >>> clearly defined (i.e. must be a multiple of 90), so it should be ok to >>> throw an exception if another value is passed. >>> Can you update your patch to throw an ePdfError_ValueOutOfRange, please? >>> >>> Thanks, >>> Dominik >>> >>> On Tue, Sep 27, 2011 at 11:05 AM, Florian Aspart >>> <[email protected]> wrote: >>> > Hi everybody, >>> > >>> > I already send this mail for few days, but I wasn't registered as an user >>> > and I'm not sure if this mail arrived. >>> > >>> > I just wanted to send a small patch. >>> > I needed to set PdfPage's rotation, there was already a getter but the >>> > setter was missing so I just add one. >>> > It's just a few line of code, the setter only set the dictionary key: >>> > 'Rotate'. >>> > >>> > Cheers, >>> > Florian >>> > >>> > >>> > ------------------------------------------------------------------------------ >>> > All the data continuously generated in your IT infrastructure contains a >>> > definitive record of customers, application performance, security >>> > threats, fraudulent activity and more. Splunk takes this data and makes >>> > sense of it. Business sense. IT sense. Common sense. >>> > http://p.sf.net/sfu/splunk-d2dcopy1 >>> > _______________________________________________ >>> > Podofo-users mailing list >>> > [email protected] >>> > https://lists.sourceforge.net/lists/listinfo/podofo-users >>> > >>> > >> >> > > ------------------------------------------------------------------------------ > All the data continuously generated in your IT infrastructure contains a > definitive record of customers, application performance, security > threats, fraudulent activity and more. Splunk takes this data and makes > sense of it. Business sense. IT sense. Common sense. > http://p.sf.net/sfu/splunk-d2d-oct > _______________________________________________ > Podofo-users mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/podofo-users > > ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2d-oct _______________________________________________ Podofo-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/podofo-users
