Hi,
thank you very much for (finding the time for it and) reviewing/
testing this change, then applying/committing it to the public
repository. This patch (with the accompanying files) was the
last one I made and posted on the island where I was on vacation
and where I had quite some issues with the (mobile broadband
volume-metered pre-paid) internet access. That were the most
important two reasons for me taking so long for writing the
program with which I generated the test PDF (after taking into
account that I'm no real expert with PoDoFo, especially when it
comes to fonts and character sets, so I had quite a bit to learn)
and revising the patch, I'm sorry for that.
For the coming months, I'll have to limit myself to less complex
patches for which I'm going to avoid topics that learning-heavy
because I'm a student and the new semester has begun.
So I'm very relieved that this and the PdfDate-"standardising"
change are now committed (and feeling grateful towards you, zyx).
This also probably enables me to post some patches I had made or
thought about making in the meantime, but which were to the same
files or even outright depending on the changes now committed (I'll
also refresh patches affected by committed changes from others).
Best regards, mabri
----- Original Message -----
From: zyx <z...@litepdf.cz>
To: podofo-users@lists.sourceforge.net
CC:
Sent: 19:54 Friday, 2 October 2015
Subject: Re: [Podofo-users] unreachable-code and robustness fixes in
PdfPagesTree::GetPageNode()
On Sat, 2015-09-19 at 00:05 +0000, Matthew Brincke wrote:
> So I hope that the patch now makes the method so robust that you'll
> accept it, please review it, and if accepted, please apply
> (separately)
> to the public repository.
Hi,
I gave a little testing to your patch and it seems to work, I didn't
notice any regression with the PDF files I tried. Interestingly, the
produced PDF seems not to be too nice, at least evince (3.16.1) is
quite unhappy about it, not being able to show other than the first
page. It can be an issue in the evince, I do not know.
I committed your change as revision 1683:
http://sourceforge.net/p/podofo/code/1683
Bye,
zyx
--
http://www.litePDF.cz i...@litepdf.cz
------------------------------------------------------------------------------
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
------------------------------------------------------------------------------
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
