On Sun, 2015-10-04 at 15:53 +0000, Matthew Brincke wrote:
> You don't rely on outcome of a method call which has invalid
> parameters, do you?

        Hi,
maybe I'm missing something here, but I rather ask before committing
your patch:

If I apply it on top of revision 1686, then the example
helloworld-base14 still claims the critical about accessing page 0 when
there are 0 pages.

Reverting back to revision 1682 avoids the critical on the console, but
it might not be the right "fix". The resulting PDF files from the
example look the same.

That is, if the helloworld-base14 does anything wrong with pages (as
the warning suggests it does), then it should be fixed as well. Thus
I'd like to ask you to correct it, either by updating the previous
patch or by sending a new one. I'll left it up to you. Bonus points if
you find more similar issues in the podofo examples/code/....

Or correct me, if I'm wrong.

        Thanks and bye,
        zyx

-- 
http://www.litePDF.cz                                 i...@litepdf.cz



------------------------------------------------------------------------------
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to