Hi Mabri!
Thanks for the updated patch! I was able to apply it now. Doxygen creation
does also work!
Best regards,
Dominik
On Mon, Jun 13, 2016 at 1:37 AM, Matthew Brincke <mabr...@ymail.com> wrote:
> Hi all,
>
> the documentation patch I alluded to before (see below) is
> now attached to this e-mail. It contains typo fixes and in
> some cases also clarification. I've let documentation stand
> which I couldn't fully understand or which is a duplicate
> (the real one being missing: for PdfString::GetUnicode()).
>
>
> I needed to compress the attachment (I used gzip) because the
> message body was too big otherwise and I didn't want it to be
> held (I cancelled the held posting).
>
> Please review and (if you are committer and accept it) please
> test (I haven't used doxygen because I'm not yet back with my
> dev env) and commit.
>
> Best regards, mabri
>
>
>
> ----- Original Message -----
> From: Matthew Brincke <mabr...@ymail.com>
> To: "podofo-users@lists.sourceforge.net" <
> podofo-users@lists.sourceforge.net>
> Sent: Friday, 10 June 2016, 16:12 UTC
> Subject: Re: [Podofo-users] Public API method names typo fixes &
> clarifications (now both parts)
>
>
>
>
> Hi all,
>
> please replace the previous patch (attached to the post I'm
> replying to) with the one attached to this post, because it
> corrects some oversights I'm sorry for & which prevent correct
> application. Please, committers, consider applying this (after
> testing, all I wrote remains in effect) to the branch and then
> merging it into trunk. I'm going to make another documentation
> patch on the weekend (e.g. for PdfString and PdfDocument) which
> will be new information (as opposed to most of this which is
> just regenerated from current svn as a base).
>
> Best regards, mabri
>
>
>
>
> ----- Original Message -----
> From: Matthew Brincke <mabr...@ymail.com>
> To: "podofo-users@lists.sourceforge.net" <
> podofo-users@lists.sourceforge.net>
> Sent: Thursday, 9 June 2016, 21:35 UTC
> Subject: Re: [Podofo-users] Public API method names typo fixes &
> clarifications (now both parts)
>
> Hi all,
>
> attached is a patch which includes just the documentation typo fixes
> because I wasn't sure whether to include changes breaking (local,
> probably also debug) symbols (not really API, but ...).
>
> Please review and (and you're committer) commit (to the branch too
> if it's admissible, please). I have *not* made a doxygen run with it
> because I haven't got the dev env right now, sorry. I've found some
> more typos I couldn't fix also because of that, I'm going to submit
> those probably on the weekend.
>
> Best regards, mabri
>
> ________________________________
>
> From: Dominik Seichter <domseich...@googlemail.com>
> To: zyx <z...@litepdf.cz>
> CC: "podofo-users@lists.sourceforge.net" <
> podofo-users@lists.sourceforge.net>
> Sent: Sunday, 7 February 2016, 16:06 UTC
> Subject: Re: [Podofo-users] Public API method names typo fixes &
> clarifications (now both parts)
>
>
>
> Hi all,
>
> I am very greatful to zyx for his work in reviewing and committing patches
> to PoDoFo! Thanks again for your efforts! Similarly, all other
> contributions to PoDoFo are welcome and these contributions are mostly
> which keeps the development ongoin nowadays.
>
> Still, I also agree with zyx that unnecessary API changes should be
> avoided.
>
> Is there a chance to create a separate patch of yours, which e.g. fixes
> only the typos in the documentation and includes all the cleanup which DO
> NOT break the API? I am quite sure this could be committed.
>
> Best regards,
> Dominik
>
>
>
> Best regards,
> Dominik
>
>
> On Mon, Feb 1, 2016 at 10:07 AM, zyx <z...@litepdf.cz> wrote:
>
> On Sun, 2016-01-31 at 23:58 +0000, Matthew Brincke wrote:
> >> I read your other e-mail about a build error, AFAIK I have corrected it
> with
> >> the patch attached to this e-mail to be applied in addition to the both
> parts.
> >
> > Hi,
> >your message is not properly threaded, I wasn't sure you talk to me
> >until I read it to the very bottom. Also because other users claimed
> >build errors in various environments recently.
> >
> >> - zyx maintains a product based on PoDoFo himself so I suspect why he
> acts like this
> >
> >Heh. Should I take this personally? I do not mind myself, as the
> >litePDF maintainer, I do not expect any massive changes being needed in
> >the litePDF project, because its main aim is drawing. I wrote both
> >reasons in the initial email. I can repeat them here again, in a more
> >verbose way, if it'll help:
> >
> >1) API changes *in any* project is a pita, especially when the API
> >change doesn't bring anything new, when it's just a cleanup of function
> >names and similar "boring" changes.
> >
> >2) I am *not* a maintainer of PoDoFo. The only reason why I have commit
> >rights to this project is that I did upstream my changes in the PoDoFo
> >drawing API. It was an API change and it allowed PoDoFo to have more
> >generic drawing API, following PDF specification closely. I believe
> >that drawing API change was a pita for exiting users too, but again, it
> >was a good change and brought many good things for the drawing. Thus,
> >as I am *not* the maintainer, it's not my duty to decide whether any
> >API change can be done or not.
> >
> >Honestly, I do not know why I take care of patches to PoDoFo from this
> >list for the past several years. I just want to return back something
> >to the community of PoDoFo, the same reason why I did upstream my
> >drawing API changes. To let people benefit from the Open Source
> >project.
> >
> >Thus no, this is not a selfish decision from my side. It's only a
> >historical experience as a developer and a user of several libraries.
> >
> > Bye,
> > zyx
> >
> >--
> >http://www.litePDF.cz i...@litepdf.cz
> >
> >
> >
>
>
> _______________________________________________
> Podofo-users mailing list
> Podofo-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/podofo-users
>
>
> ------------------------------------------------------------------------------
> What NetFlow Analyzer can do for you? Monitors network bandwidth and
> traffic
> patterns at an interface-level. Reveals which users, apps, and protocols
> are
> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
> J-Flow, sFlow and other flows. Make informed decisions using capacity
> planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e
> _______________________________________________
> Podofo-users mailing list
> Podofo-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/podofo-users
>
>
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports. http://pubads.g.doubleclick.net/gampad/clk?id=1444514421&iu=/41014381
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
