Hello Francesco, hello all,
> On 18 January 2019 at 15:05 Matthew Brincke <ma...@mailbox.org> wrote:
> patch and the fix because I'd like to accept the first two
> patches in this series today (commit them after testing with
> different compilers on GNU/Linux).
I retract my acceptance of [PATCH 1/5] because I've found some
posts [1] to the mailing list which show that it's problematic
(non-portable at least, but can lead to crashes). I'll instead
change the signed type pdf_int8 to pdf_uint8 because I don't
think casting a possibly-negative value to an enum makes sense
(though of course I can't give credit for that).
The [PATCH 2/5] looks fine, but I'd like to put it on hold for
a bit because the location it's to be applied to is implicated
in issue #39 [2] and I plan to analyze and fix that first.
Best regards, mabri
[1] the post "Re: [Podofo-users] 0.9.5 regression,
pdfImage.GetObject()->GetDictionary() throws exception",
Message-ID <1487271019.6643.11.ca...@litepdf.cz>, archive
URL https://sourceforge.net/p/podofo/mailman/message/35670448/
shows a committer's acceptance of a bug report and his proposed
fix which is the opposite of yours. The bug analysis itself is
in Sandro Mani's post of 2017-02-11 02:12:33 UTC, archive URL
https://sourceforge.net/p/podofo/mailman/message/35659963/
[2] https://sourceforge.net/p/podofo/tickets/39/
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
