Maybe I would personally did not add new parameter but instead tried to fix it in way that value passed to SetIgnoreBrokenObjects() is not overwritten in Init() and make true the default. But I am ok also with current patch so I do not plan to do this. If someone wants he/she can do.
On Fri, Feb 21, 2020 at 7:45 PM Michal Sudolsky <sudols...@gmail.com> wrote: > Hi, > > I do not think that this patch is bad. It fixes problems and can be > amended also later to ignore broken objects by default so there is no > reason to not apply it in its current form. Except that someone does not > like new parameter in "Load" functions but wants to turn it on or off using > some class member method. > > On Thu, Feb 20, 2020 at 8:27 AM zyx <z...@gmx.us> wrote: > >> On Wed, 2020-02-19 at 16:57 +0100, Michal Sudolsky wrote: >> > I think ignoring broken objects should be the default behaviour >> >> Hi, >> I can second that, it makes perfect sense. >> >> Thanks for the corrected review of the patch. I only briefly read it, >> which did not reveal any obvious problem. I didn't test it in action. >> My fault. >> >> Bye, >> zyx >> >> >> >> _______________________________________________ >> Podofo-users mailing list >> Podofo-users@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/podofo-users >> >
_______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
