On Tue, 2019-01-15 at 13:48 +0100, Michal Sudolsky wrote:
> Hi,
> By the way when making podofo 0.9.6 on osx there are these 2
> warnings:
>
> podofo-0.9.6/src/base/PdfParser.cpp:899:31: warning: format specifies
> type 'long *' but the argument has type 'PoDoFo::pdf_int64 *' (aka
> 'long long *') [-Wformat]
>
> &llOffset, &llGeneration, &cUsed, &empty1, &empty2 );
> podofo-0.9.6/src/base/PdfParser.cpp:899:42: warning: format specifies
> type 'long *' but the argument has type 'PoDoFo::pdf_int64 *'
> (aka 'long long *') [-Wformat]
>
> &llOffset, &llGeneration, &cUsed, &empty1, &empty2 );
Hi,
this is long time ago. I checked the code above (at r2008) and it looks
like this:
int read = sscanf( m_buffer.GetBuffer(), "%10" PDF_FORMAT_INT64 " %5"
PDF_FORMAT_INT64 " %c%c%c",
&llOffset, &llGeneration, &cUsed, &empty1, &empty2 );
which makes me think that PDF_FORMAT_INT64 is not properly set on OSX,
or the sscanf() cannot decipher it properly. Both feels unlikely, but I
do not have any environment to test it with.
> On linux:
>
> podofo-0.9.6/tools/podofocolor/podofocolor.cpp: In function
> ‘IConverter* ConverterForName(const string&, const string&)’:
> podofo-0.9.6/tools/podofocolor/podofocolor.cpp:50:89: warning: unused
> parameter ‘lua’ [-Wunused-parameter]
> static IConverter* ConverterForName( const std::string & converter,
> const std::string & lua )
I do not see this one too. Do you build with LUA? The code in question
looks properly, from my point of view:
#ifdef PODOFO_HAVE_LUA
else if( converter == "lua" )
{
pConverter = new LuaConverter( lua );
}
#else
PODOFO_UNUSED_PARAM( lua )
#endif // PODOFO_HAVE_LUA
I do see unused parameter warnings from other functions, thus it is
enabled here.
Bye,
zyx
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
