>
>
>     if( !i )
>     {
>         PODOFO_RAISE_ERROR( ePdfError_InternalLogic );
>     }
>
> If token keyword is found exactly at position 512 bytes before EOF
> (suppose pdf is larger than 512 bytes) then it will throw
> ePdfError_InternalLogic ("break" will happen when i == 0). There probably
> should have been if( i < 0 ) because if token is not found then i will be
> negative (-1) and not zero (this is also indicated in that comment where is
> i defined) and in this case that error probably should have been something
> like "invalid pdf" not "internal logic error". I would add new issue on
> github but is this resolved in pdfmm?
>
>
Actually that "if" should be probably removed altogether (if I did not miss
something) because non-existence of the token keyword is generally checked
after a call to FindToken.



> Best Regards,
>>
>> Dennis Voss
>> --
>>
>> [image: dots Software] <http://www.dots.de/en/>
>>
>> Dennis Voss
>> Lead Programmer
>>
>> dots Gesellschaft für Softwareentwicklung mbH
>> Schlesische Str. 27, 10997 Berlin, Germany
>>
>> Tel: +49 (0)30 695 799-30
>>
>> dennis.v...@dots.de <max.musterm...@dots.de>
>> https://www.dots.de
>>
>> District court | Amtsgericht: Berlin Charlottenburg HRB 65201
>> Managing Director | Geschäftsführer: Katsuji Kondo
>>
>>
>> _______________________________________________
>> Podofo-users mailing list
>> Podofo-users@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/podofo-users
>>
>
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to