Hey Francesco and Michal,

first of all, thanks for taking a look! I havent had this code reviewed at my end, so im happy to see you doing it!

But please dont mix up topics like that. Im not talking about pdfmm and its refactored code. It is good that you check pdfmm for this bug too, but i am confused now about what code and discussions you guys actually have (topic backwards search). Are you talking podofo, are you talking pdfmm? Are you in general talking about backwards searches in the codebase? And please answer "the list" and not "answer all" i have all of your mails twice now... its very confusing for me.

One bug in one thread at a time please :-)


Francesco: Yes PoDoFo crashes when loading my provided file (you can also try to open it with podofobrowser, it also crashes with the error that the 'trailer' is not found).

Michal: You are correct in assuming that the word 'trailer' in the comments would be a problem, i didnt think about that... i also dont know off the top of my head how to fix this easily. I havent looked at pdfmm's implementation but if that doesnt crash (according to Francesco) maybe PoDoFo should be changed to that.

"What if xref itself is between trailer and startxref?": if im not misunderstanding it this should be prohibited according to pdf spec Version 1.7 section 7.5.5 "File trailer" (or my pdf spec is too old :-) )


Best Regards,

Dennis


--

dots Software <http://www.dots.de/en/>

Dennis Voss
Lead Programmer

dots Gesellschaft für Softwareentwicklung mbH
Schlesische Str. 27, 10997 Berlin, Germany

Tel: +49 (0)30 695 799-30

dennis.v...@dots.de <mailto:max.musterm...@dots.de>
https://www.dots.de

District court | Amtsgericht: Berlin Charlottenburg HRB 65201
Managing Director | Geschäftsführer: Katsuji Kondo
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to