On Wed, 2023-03-08 at 23:36 +0100, Francesco Pretto wrote:
> If no major discussion or bug fixing is required, I think we can have
> a 0.10.0 in a week/ten days
Hi,
I took the latest git checkout and gave it a try. The library builds
fine, no warnings shown. There is one CMake warning when I use the
configure options I used for the trunk build:
CMake Warning:
Manually-specified variables were not used by the project:
PODOFO_BUILD_SHARED
PODOFO_BUILD_STATIC
I suppose these two had been renamed?
The tools are not part of the `all` target and `make help` doesn't show
anything similar to the tools, thus those are not build here at all. I
guess they should be part of the `all` target.
The helloworld-base14 fails here with the following output:
--------------------------------------------
$ ./_build/target/helloworld-base14 /tmp/a.pdf
Times-Roman Width = 279.12 Height = 1
Times-Italic Width = 269.112 Height = 1
Times-Bold Width = 277.992 Height = 1
Times-BoldItalic Width = 296.16 Height = 1
Helvetica Width = 275.304 Height = 1
Helvetica-Oblique Width = 321.864 Height = 1
Helvetica-Bold Width = 316.608 Height = 1
Helvetica-BoldOblique Width = 360.948 Height = 1
Courier Width = 309.6 Height = 1
Courier-Oblique Width = 367.2 Height = 1
Courier-Bold Width = 345.6 Height = 1
Courier-BoldOblique Width = 396 Height = 1
Symbol Width = 272.712 Height = 0.9
ERROR:
PoDoFo encountered an error. Error: 31PdfErrorCode::InvalidFontData Error
Description: The font data is invalid. Callstack: #0 Error Source :
main/PdfEncoding.cpp: 82 Information: The provided string can't be
converted to CID encoding
--------------------------------------------
Note of the printed error, it seems like it could be a multiline text,
with indentation, but it's shown as one long line instead. I think this
used to work in the past, but I can be wrong.
Running svn's trunk helloworld-base14 works without any error (and both
helloworld-s do contain "Hello World" string in the PDF, while the git
does not).
By the way, I found it weird to find the built helloworld files in the
`_build/target/` directory, but it is more like a habit to look for the
built files/binaries in the directory they are defined in (in this case
under `_build/examples/...`). I agree it makes sense to have the
executables beside the library they use, especially when the RPATH is
disabled.
The trunk's unit tests contain some CVE-related tests. It makes the
test suite quite slow. I did not try to hunt the sources whether you've
them included or not, I'm sorry for being lazy, did you just drop those
tests or they need special invocation to be included in the list of the
unit tests, please?
I did not do any real testing, this was just a quick smoke testing. In
any case, the first impression is really good. Thank you for it.
Bye,
zyx
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
