On Fri, 10 Mar 2023 at 07:53, zyx <z...@gmx.us> wrote: > > On Thu, 2023-03-09 at 18:18 +0100, Francesco Pretto wrote: > I passed the parameters as: > -DPODOFO_BUILD_SHARED=OFF \ > -DPODOFO_BUILD_STATIC=ON \ > thus I did not want to build both targets. > > Does the rename make sense, I mean PODOFO_BUILD_STATIC to > PODOFO_STATIC?
There were some ideas[1] to support dual static/shared targets that would be manually enabled and available in the build system by setting both PODOFO_BUILD_STATIC and PODOFO_BUILD_SHARED to TRUE. It can't be done easily right now because there is the new podofo_private target (which can be used by the library/tests/tools) that complicates stuff. I would let those variables free for now and have just a single switchable PODOFO_STATIC variable that decides if the whole build system (that includes also tests/tools/library) is using a statically compiled library when TRUE or a shared one when FALSE (the default). A symmetric PODOFO_SHARED cannot be set externally, which should make it less confusing. > The PODOFO_BUILD_LIB_ONLY is not called PODOFO_LIB_ONLY, > right? I mean PODOFO_BUILD_STATIC might fit better. Maybe. Maybe not. > There's no PODOFO_LIB_ONLY, not even in 0.9.x, so I don't know exactly what you mean. If PODOFO_BUILD_LIB_ONLY is confusing we can rename it to PODOFO_BUILD_LIBRARY_ONLY, which if enabled will skip building tests/tools/examples (was the same in 0.9.x). > Okay, makes sense to me. If they could be enabled in runtime, by some > switch or whatever, then it'll be a nice bonus. Otherwise those tests > were really slow and might not be part of a usual unit tests run, > because unit tests should be quick (at least from my point of view). > I think with catch2 it's possible to tag tests and control which tests to run with command line: https://github.com/catchorg/Catch2/blob/devel/docs/test-cases-and-sections.md https://github.com/catchorg/Catch2/blob/devel/docs/command-line.md#top It's not a priority for me. I will wait Mark or others to have a look and suggest something later. Regards, Francesco [1] https://github.com/podofo/podofo/issues/34#issuecomment-1407792409 > > Thanks and bye, > zyx > > > _______________________________________________ > Podofo-users mailing list > Podofo-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/podofo-users _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
