Re: Please review these FormulaParser Changes - Diff Version

[Danny Mui]

I agree completely but but but, im using a linkedlist specifically 
because i want to use it's specific features, getFirst() getLast() etc.  
I suppose I can switch to using indices but then that sort of only gives 
me one benefit from using the linked list (theoritcally should be more 
efficient, not using API simplification).

decisions! decisions! ;)

thanks!

danny

Rainer Klute wrote:

Not that I could comment on your patch but this one caught my eyes:

 

+    private LinkedList functionTokens = new LinkedList();
   

You should program against the interface, not the class. Therefore the
statement should be
private List functionTokens = new LinkedList();

Best regards
Rainer Klute
 



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]