Re: Please review these FormulaParser Changes - Diff Version

[Andrew C. Oliver]

My opinion is that Rainer is right.  However, I'm certainly not vetoing 
anything based on this kind of thing.

I do think you need to excercise due care with regards to unit tests for 
this.  Formula parsing is a nasty beast
and I assure you, I will break your code next time I start hacking on it 
if there is no unit test to stop me.  :-)
Only I'll believe that my changes MUST be right...since all the unit 
tests pass ;-)

-Andy

Rainer Klute wrote:

I agree completely but but but, im using a linkedlist 
   

specifically
 

because i want to use it's specific features, getFirst() 
   

getLast() etc.
 

I suppose I can switch to using indices but then that sort of 
   

only gives
 

me one benefit from using the linked list (theoritcally should 
   

be more
 

efficient, not using API simplification).
   

list.get(0) and list.get(list.size() - 1) should not give you 
any considerable performance penalty. I don't know how it is 
implemented but I where to implement a get() method for a doubly 
linked list I'd find out whether the index is closer to the 
beginning of the list or closer to its end and start traversing 
the list from there. Thus list.get(0) and list.get(list.size() - 
1) should perform well.

Best regards
Rainer Klute
                          Rainer Klute IT-Consulting GmbH
 Dipl.-Inform.
 Rainer Klute             E-Mail:  [EMAIL PROTECTED]
 K�rner Grund 24          Telefon: +49 172 2324824
D-44143 Dortmund           Telefax: +49 231 5349423


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
 





---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]