Hi and thanks, breaking change was glued now :)
Back you get some quick feedback:
1.) Not nice. I expected help
C:\>crisper
path.js:116
throw new TypeError('Arguments to path.resolve must be strings');
^
TypeError: Arguments to path.resolve must be strings
at Object.exports.resolve (path.js:116:15)
at Object.exports.relative (path.js:240:18)
at Object.<anonymous>
(C:\Users\x\AppData\Roaming\npm\node_modules\crisper\bin\crisper:35:25)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Function.Module.runMain (module.js:497:10)
at startup (node.js:119:16)
at node.js:902:3
2.) You could also mention that linking to scripts in index.html is not
necessary anymore (since I was using it like this). Guess this part is in
crisper now
<script src="all.js"></script>
3.) You could also say that crisper command should be
crisper --source vulcanized.html --html build.html --js build.js
since vulcanized.html is vulcanize's default output file name
instead of
crisper --source index.html --html build.html --js build.js
which produces 0byte build.js and a copy of index.html and appended
build.js at the end in the build.html file (as observed)
4.) Piping does not work
vulcanize index.html | crisper --html build.html --js build.js
produces 0byte build.js and following line in build.html
<html><head></head><body><script src="build.js"></script></body></html>
5.) What worked (from my point of view / as I expect)
vulcanize index.html
crisper --source vulcanized.html --html build.html --js build.js
Kr,
Ainur
On Monday, April 13, 2015 at 8:30:34 PM UTC+2, Daniel Freedman wrote:
>
> I factored out the CSP component into a new project called crisper:
> https://github.com/polymerlabs/crisper.
>
> You can pipe the output of vulcanize through crisper to make separate JS
> and HTML files:
>
> vulcanize target.html | crisper --html build.html --js build.js
>
> I'll put this into the README of vulcanize.
>
> On Mon, Apr 13, 2015 at 8:38 AM, Eric Bidelman <[email protected]
> <javascript:>> wrote:
>
>> +Daniel Freedman <javascript:>
>>
>> On Mon, Apr 13, 2015 at 7:32 AM Silver Techar <[email protected]
>> <javascript:>> wrote:
>>
>>> Hi,
>>>
>>> How do you do following v.0.7 vulcanize command in the braeking v.1 ?
>>>
>>> My vulacnize v.0.7 command was: vulcanize -o ../build.html ../index.html
>>> --strip --csp
>>>
>>> where index.html looked something like
>>>
>>> <!doctype html>
>>> <html>
>>> <head>
>>> <script src="all.js"></script>
>>>
>>> <link rel="import"
>>> href="bower_components/paper-input/paper-input.html">
>>> ..etc..
>>> </head>
>>> <body>
>>> <x-app></x-app>
>>> </body>
>>> </html>
>>>
>>>
>>> Ref: https://github.com/Polymer/vulcanize/blob/master/CHANGELOG.md
>>>
>>> Kr,
>>> Ainur
>>>
>>> Follow Polymer on Google+: plus.google.com/107187849809354688692
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "Polymer" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to [email protected] <javascript:>.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/polymer-dev/75741b5b-51f8-4bbe-8f42-9ed85cbdbfbc%40googlegroups.com
>>>
>>> <https://groups.google.com/d/msgid/polymer-dev/75741b5b-51f8-4bbe-8f42-9ed85cbdbfbc%40googlegroups.com?utm_medium=email&utm_source=footer>
>>> .
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>
Follow Polymer on Google+: plus.google.com/107187849809354688692
---
You received this message because you are subscribed to the Google Groups
"Polymer" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/polymer-dev/3fee38d4-58e4-48de-a5a3-b7efc33493fd%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
