Hi and thanks, 
breaking change was glued now :)

Here is some quick feedback:


1.) I expected help when executing command without arguments

C:\>crisper

path.js:116
        throw new TypeError('Arguments to path.resolve must be strings');
              ^
TypeError: Arguments to path.resolve must be strings
    at Object.exports.resolve (path.js:116:15)
    at Object.exports.relative (path.js:240:18)
    at Object.<anonymous> 
(C:\Users\x\AppData\Roaming\npm\node_modules\crisper\bin\crisper:35:25)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:902:3
   
2.) You could say that crisper command should be
crisper --source vulcanized.html --html build.html --js build.js
since vulcanized.html is vulcanize's default output file name

instead of
crisper --source index.html --html build.html --js build.js
which produces 0byte build.js and a copy of index.html and appended 
<x-app></x-app><script src="build.js"></script></body></html> at the end 
inside of build.html (as observed)

3.) Piping does not work
    vulcanize index.html | crisper --html build.html --js build.js
   
    produces 0byte build.js and following line in build.html
    <html><head></head><body><script src="build.js"></script></body></html>



What worked (from my point of view / as I expect)

vulcanize index.html
crisper --source vulcanized.html --html build.html --js build.js   


Thx for polymer and vulcanize!

Kr,
Ainur

Follow Polymer on Google+: plus.google.com/107187849809354688692
--- 
You received this message because you are subscribed to the Google Groups 
"Polymer" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/polymer-dev/c5856809-721d-4057-8e5d-09e4dd19e27b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to