On Tue, Dec 21, 2021 at 10:43:37AM +0300, Andrew Krasavin wrote:
On Tue, Dec 21, 2021 at 08:18:04AM +0100, Rafael Sadowski wrote:
On Tue Dec 14, 2021 at 04:20:56PM -0700, Klemens Nanni wrote:
CVSROOT: /cvs
Module name: ports
Changes by: [email protected] 2021/12/14 16:20:56
Modified files:
multimedia/mpv : Makefile
multimedia/mpv/patches: patch-audio_out_ao_c
patch-audio_out_ao_sndio_c patch-wscript
patch-wscript_build_py
Log message:
Reinstate the sndio backend
From Brad, tested by many.
OK bcallah op
Seeking works bady with this commit. My key options
(.config/mpv/input.conf):
## Seek units are in seconds, but note that these are limited by keyframes
j seek 2
k seek -2
h seek 6
l seek -6
This worked much better without this patch. Can anyone confirm this?
Hello!
I am the author of the latest version of this patch (trying to get
it included in the upstream here[1]).
I was not aware of this problem, thanks for the report!
I will now try to reproduce and figure out what's wrong.
Given the fact that I have to go to work in the next hour, you
should hardly expect a good solution before tonight/night
(that's an optimistic estimate anyway, alas).
1. https://github.com/mpv-player/mpv/pull/9298
--
Wbr, Andrew Krasavin
Unfortunately, I have not yet been able to figure out exactly what
the problem is with seek + mpv with ao_sndio from #9298.
I deleted all entries from my ~/.config/mpv/config, created
~/.config/mpv/input.conf which is an exact copy of yours.
Next, I tried playing different videos (mp4[*] and webm) and then
moving through them in large segments in different directions
randomly.
I didn't notice any weirdness.
Then I built mpv 0.34 with ao_sndio from #8314 (the original version
of the patch from Ivan Rozhuk) and roughly repeated my steps.
Notice the difference could not.
I probably just don't understand what exactly I'm talking about.
If it's not too much trouble:
1) Please describe in more detail exactly how the problem manifests
itself. What exactly should I see? What exactly is the difference
from the previous version?
2) If you delete all mpv settings except the input.conf you quoted,
does the problem reproduce?
3) Does the problem play on any videos or any specific videos? If
the second, please give examples.
I don't care where I get feedback from you - by mail or on github
- whichever is more convenient for you. Thank you in advance.
[*] : When seeking in some mp4 videos with hjkl, there were
messages like "[ffmpeg/video] h264: mmco: unref short failure"
in the mpv log, but it had no effect on smoothness of work, audio
and video synchronization or anything like that.
--
Wbr, Andrew Krasavin
