On Tue Dec 21, 2021 at 12:54:16PM +0300, Andrew Krasavin wrote: > On Tue, Dec 21, 2021 at 10:43:37AM +0300, Andrew Krasavin wrote: > > On Tue, Dec 21, 2021 at 08:18:04AM +0100, Rafael Sadowski wrote: > > > On Tue Dec 14, 2021 at 04:20:56PM -0700, Klemens Nanni wrote: > > > > CVSROOT: /cvs > > > > Module name: ports > > > > Changes by: [email protected] 2021/12/14 16:20:56 > > > > > > > > Modified files: > > > > multimedia/mpv : Makefile > > > > multimedia/mpv/patches: patch-audio_out_ao_c > > > > patch-audio_out_ao_sndio_c patch-wscript > > > > patch-wscript_build_py > > > > > > > > Log message: > > > > Reinstate the sndio backend > > > > > > > > From Brad, tested by many. > > > > OK bcallah op > > > > > > > > > > Seeking works bady with this commit. My key options > > > (.config/mpv/input.conf): > > > > > > ## Seek units are in seconds, but note that these are limited by keyframes > > > j seek 2 > > > k seek -2 > > > h seek 6 > > > l seek -6 > > > > > > This worked much better without this patch. Can anyone confirm this? > > > > > > > Hello! > > > > I am the author of the latest version of this patch (trying to get > > it included in the upstream here[1]). > > > > I was not aware of this problem, thanks for the report! > > I will now try to reproduce and figure out what's wrong. > > > > Given the fact that I have to go to work in the next hour, you > > should hardly expect a good solution before tonight/night > > (that's an optimistic estimate anyway, alas). > > > > 1. https://github.com/mpv-player/mpv/pull/9298 > > > > -- > > Wbr, Andrew Krasavin > > > > Unfortunately, I have not yet been able to figure out exactly what > the problem is with seek + mpv with ao_sndio from #9298.
First of all, I would like to apologise if my first email was too rude. > > I deleted all entries from my ~/.config/mpv/config, created > ~/.config/mpv/input.conf which is an exact copy of yours. > > Next, I tried playing different videos (mp4[*] and webm) and then > moving through them in large segments in different directions > randomly. > I didn't notice any weirdness. > > Then I built mpv 0.34 with ao_sndio from #8314 (the original version > of the patch from Ivan Rozhuk) and roughly repeated my steps. > > Notice the difference could not. > > I probably just don't understand what exactly I'm talking about. > > If it's not too much trouble: > > 1) Please describe in more detail exactly how the problem manifests > itself. What exactly should I see? What exactly is the difference > from the previous version? If you seek fast (hold the seek key pressed all the time) then you shouldn't see such hard breaks. > > 2) If you delete all mpv settings except the input.conf you quoted, > does the problem reproduce? Yes, see below. Instead using "j" I have to use ">" aka. AXIS_LEFT. > > 3) Does the problem play on any videos or any specific videos? If > the second, please give examples. Some are a little better and some are worse. But in general, the patch has made them worse. (Not an show stopper for me) > > I don't care where I get feedback from you - by mail or on github > - whichever is more convenient for you. Thank you in advance. I wasn't at the keyboard over the change of year. So I apologise for my late reply. > > [*] : When seeking in some mp4 videos with hjkl, there were > messages like "[ffmpeg/video] h264: mmco: unref short failure" > in the mpv log, but it had no effect on smoothness of work, audio > and video synchronization or anything like that. My test case, to be honest a bit harsh: $ mpv The\ Future\ of\ Intelligence,\ Artificial\ and\ Natural\ \ \ _\ \ \ Ray\ Kurzweil\ \(USA\)\ .\ \[JbKNbMgRbJA\].webm (+) Video --vid=1 (*) (vp9 1280x720 25.000fps) (+) Audio --aid=1 --alang=eng (*) (opus 2ch 48000Hz) AO: [sndio] 48000Hz stereo 2ch s16 VO: [gpu] 1280x720 yuv420p AV: 00:22:01 / 01:02:57 (35%) A-V: -0.000 and hold pressed "j" key (j seek 2) and don't release the j key. Tested with: yt-dlp https://www.youtube.com/watch?v=JbKNbMgRbJA (multimedia/yle-dl) All in all, it's not a big issue. I only use it when I want to "slide" through the entire video. Thanks for working and caring on the topic. Rafael
