Marc Espie: > CVSROOT: /cvs > Module name: ports > Changes by: [email protected] 2018/11/03 03:54:55 > > Added files: > graphics/piglit/patches: > > patch-tests_spec_ext_framebuffer_multisample_draw-buffers-common_cpp > patch-tests_util_piglit-test-pattern_cpp > > Log message: > somehow, some tests found their way into compilation, and broke it thanks > to C++11 narrowing issues. Obvious fixes to the code (no bump, didn't build > before)
This is wrong and misses the actual problem. As I wrote on ports@: -------------------> The failure chain is this: * pkg_check_modules(GBM QUIET gbm>=17.1) now succeeds. * "-lgbm -Wl,-rpath-link,/usr/X11R6/lib:/usr/local/lib" is added to the compiler flags. * This causes error "/usr/bin/ld: error: unable to find library -lgbm". * Which breaks all subsequent compile tests, including one for -Wno-narrowing. * Eventually, the build fails with "error: non-constant-expression cannot be narrowed ..." in some C++ code. <------------------- The cmake test needs to be fixed. The patches above should be reverted. -- Christian "naddy" Weisgerber [email protected]
