On Mon, Nov 05, 2018 at 04:37:48PM +0100, Christian Weisgerber wrote: > The cmake test needs to be fixed. The patches above should be > reverted.
Not really. -Wnarrowing is a tolerance for non modern code. Fixing narrowing constants by explicit casting is always a good idea. We didn't do it for "large ports with lots of problems", but two patches that allow code to be C++11 compliant is a good idea. I should send the patches upstream anyway. I fully subscribe to the opinion that this error is a good thing, and that preventing initialization of possibly narrowed constants will help find actual errors in the long run.
