On Tue, Apr 06, 2021 at 10:26:49AM +0100, Stuart Henderson wrote: > Ohhhh I see what it's doing. Yeuch. > > 'This is a "best effort" parser. If it errors out, we instead end up relying > on the PyQtWebEngine version, which is the next best thing.' > > This suggests that the fallback is not working correctly. We aren't doing > anything funny with the PyQtWebEngine version.
For some reason the fallback reports Chromium version as 87.x instead of 83.x which we have. Debug output (just below the logo): http://ix.io/2V9a I haven't looked into this further to see exactly why PyQt reports the wrong version. QtWebEngine is reported as 5.15.4 instead of 5.15.2. > > > -- > Sent from a phone, apologies for poor formatting. > On 6 April 2021 09:41:02 Anindya Mukherjee <[email protected]> wrote: > > > On Tue, Apr 06, 2021 at 09:16:29AM +0100, Stuart Henderson wrote: > > > On 2021/04/05 19:56, Anindya Mukherjee wrote: > > > > Hi, > > > > > > > > Qutebrowser has a bug on OpenBSD which causes the prefers-color-scheme > > > > setting to not work correctly (e.g., test sites show that it is not > > > > supported, etc.). The problem is a hard-coded library filename for > > > > libQt5WebEngineCore.so.5 in > > > > /usr/local/lib/python3.8/site-packages/qutebrowser/misc/elf.py. I worked > > > > with The-Compiler and a fix has been committed upstream: > > > > https://github.com/qutebrowser/qutebrowser/commit/eb6f1cf9898cb431af9d2812ec40f811e37f57f0 > > > > Would it be possible to backport this into the current port? I have > > > > tested the patch on my system and it fixes the issue. To test, simply > > > > set colors.webpage.preferred_color_scheme = dark and load > > > > https://www.openbsd.org/faq/. It will be displayed using the light > > > > scheme without this fix, regardless of the above setting. > > > > > > > > OTOH 2.2 is not too far off and updating to that won't need maintaining > > > > a patch. I'm not sure what is the best way to proceed. > > > > > > > > Regards, > > > > Anindya > > > > > > > > > > The fix is not correct, it should not check for existence of the file, > > > just > > > try to dlopen libQt5WebEngineCore.so (no version). > > > > > > See dlopen(3) "When a shared library is specified without a version ..." > > > > > > > Thanks, this makes sense. In fact in my own C code I do exactly what you > > suggested. I'll chat with upstream to see if this can be done in the > > python code and avoid looping through a file list. > > > > Regards, > > Anindya >
